bakaid commented on a change in pull request #713: MINIFICPP-1119 unify
win/posix sockets + clean up issues
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377124752
##########
File path: libminifi/include/io/BaseStream.h
##########
@@ -46,13 +46,12 @@ class BaseStream : public DataStream, public Serializable {
: composable_stream_(this) {
}
- BaseStream(DataStream *other)
+ explicit BaseStream(DataStream *other)
Review comment:
This breaks API.
I agree with the change, but if someone depended on BaseStream being
implicitly constructible from DataStream, we would break their usage, which we
cannot do in a minor release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
