bakaid commented on a change in pull request #713: MINIFICPP-1119 unify
win/posix sockets + clean up issues
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377143374
##########
File path: libminifi/src/io/tls/TLSSocket.cpp
##########
@@ -170,22 +174,19 @@ void TLSSocket::closeStream() {
* @param listeners number of listeners in the queue
*/
TLSSocket::TLSSocket(const std::shared_ptr<TLSContext> &context, const
std::string &hostname, const uint16_t port, const uint16_t listeners)
- : Socket(context, hostname, port, listeners),
- ssl_(0) {
+ : Socket(context, hostname, port, listeners) {
logger_ = logging::LoggerFactory<TLSSocket>::getLogger();
context_ = context;
}
TLSSocket::TLSSocket(const std::shared_ptr<TLSContext> &context, const
std::string &hostname, const uint16_t port)
- : Socket(context, hostname, port, 0),
- ssl_(0) {
+ : Socket(context, hostname, port, 0) {
logger_ = logging::LoggerFactory<TLSSocket>::getLogger();
context_ = context;
}
-TLSSocket::TLSSocket(const TLSSocket &&d)
- : Socket(std::move(d)),
- ssl_(0) {
+TLSSocket::TLSSocket(TLSSocket &&d) noexcept
Review comment:
I think this implementation is wrong (it was wrong before this PR).
TLSSocket has a bunch of data members that are ignored by this move
constructor, among them an std::map, whose move constructor is not noexcept, as
far as I know, so TLSSocket's can't be either.
Not to mention that the single data member it does not ignore is copied, but
since that's a shared_ptr, that part might have actually worked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
