bakaid commented on a change in pull request #743: Minificpp 1169 - Simplify C2
metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r388244326
##########
File path: libminifi/include/properties/Configure.h
##########
@@ -36,10 +36,21 @@ class Configure : public Properties {
std::lock_guard<std::mutex> lock(mutex_);
agent_identifier_ = identifier;
}
- std::string getAgentIdentifier() {
+ std::string getAgentIdentifier() const {
std::lock_guard<std::mutex> lock(mutex_);
return agent_identifier_;
}
+
+ void setAgentClass(const std::string& agentClass) {
+ std::lock_guard<std::mutex> lock(mutex_);
+ agent_class_ = agentClass;
+ }
+
+ std::string getAgentClass() const {
+ std::lock_guard<std::mutex> lock(mutex_);
+ return agent_class_;
+ }
+
Review comment:
New configuration options (`nifi.c2.full.heartbeat`) should be added to
`Configure.h` and `Configure.cpp` as `static const char *` members, like the
rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
