bakaid commented on a change in pull request #743: Minificpp 1169 - Simplify C2
metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r388283597
##########
File path: libminifi/include/utils/ThreadPool.h
##########
@@ -412,6 +414,22 @@ class ThreadPool {
void run_tasks(std::shared_ptr<WorkerThread> thread);
};
+template<typename T>
+bool ThreadPool<T>::execute(Worker<T> &&task) {
Review comment:
If this is going to remain in the final version, the non-future returning
and future returning version should be deduplicated.
Also, @arpadboda is currently working on a ThreadPool refactor/fix, I think
it would be prudent to discuss any change to ThreadPool (and any new usage)
with him.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
