arpadboda commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r389968278
########## File path: libminifi/include/c2/C2Agent.h ########## @@ -244,6 +239,10 @@ class C2Agent : public state::UpdateController, public state::response::Response std::string bin_location_; std::shared_ptr<logging::Logger> logger_; + + utils::ThreadPool<state::Update> heartbeat_thread_pool_; Review comment: I'm afraid it's going to conflict with my threadpool PR, which is about having one single threadpool. In case that gets merged before this, let's have a talk to fit this in that architecture. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
