arpadboda commented on a change in pull request #743: Minificpp 1169 - Simplify
C2 metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r389963074
##########
File path: extensions/http-curl/tests/HTTPIntegrationBase.h
##########
@@ -91,4 +87,64 @@ void CoapIntegrationBase::setUrl(std::string url,
CivetHandler *handler) {
}
}
+class VerifyC2Base : public CoapIntegrationBase {
+ public:
+ explicit VerifyC2Base(bool isSecure)
+ : isSecure(isSecure) {
+ }
+
+ virtual void testSetup() {
+ LogTestController::getInstance().setDebug<utils::HTTPClient>();
+ LogTestController::getInstance().setDebug<LogTestController>();
+ }
+
+ void runAssertions() {
Review comment:
This should be defined by any derived class (to make sure they test
something), so I think you can delete it.
That has the advantage of making this baseclass abstract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
