szaszm commented on a change in pull request #754: MINIFICPP-1151 fix most 1st
party compiler warnings
URL: https://github.com/apache/nifi-minifi-cpp/pull/754#discussion_r408212082
##########
File path: libminifi/test/sensors-tests/SensorTests.cpp
##########
@@ -78,7 +78,7 @@ class PcapTestHarness : public IntegrationBase {
}
protected:
- char *dir;
+ std::string dir;
Review comment:
On line 50, `createTempDirectory` returns a reference to the local `format`
buffer, making this member dangling after construction in the old version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
