szaszm commented on a change in pull request #754: MINIFICPP-1151 fix most 1st
party compiler warnings
URL: https://github.com/apache/nifi-minifi-cpp/pull/754#discussion_r408200309
##########
File path: libminifi/include/core/PropertyValue.h
##########
@@ -210,8 +210,8 @@ class PropertyValue : public state::response::ValueNode {
std::shared_ptr<PropertyValidator> validator_;
};
-inline char const* conditional_conversion(const PropertyValue &v) {
- return v.getValue()->getStringValue().c_str();
+inline std::string conditional_conversion(const PropertyValue &v) {
Review comment:
This breaks API, but seems to be only used on Logger on our side. If this is
a problem, feel free to open an issue.
The previous version returned a pointer to a temporary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
