szaszm commented on a change in pull request #754: MINIFICPP-1151 fix most 1st party compiler warnings URL: https://github.com/apache/nifi-minifi-cpp/pull/754#discussion_r408207929
########## File path: main/MiNiFiWindowsService.cpp ########## @@ -28,6 +28,15 @@ #include "core/FlowConfiguration.h" //#define DEBUG_SERVICE +#ifdef LOG_INFO + #undef LOG_INFO +#endif +#ifdef LOG_ERROR + #undef LOG_ERROR +#endif +#ifdef LOG_LASTERROR + #undef LOG_LASTERROR +#endif Review comment: macro redefinition below ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
