[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692852#comment-17692852
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116137978
##########
opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java:
##########
@@ -444,33 +450,33 @@ else if (1 - cprobs[completeIndex] > probMass) { //just
incomplete advances
if (cprobs[completeIndex] > probMass) {
setComplete(updatedNode);
newParse2.addProb(StrictMath.log(cprobs[completeIndex]));
- if (debugOn) System.out.println("Only advancing complete
node");
+ if (logger.isDebugEnabled()) logger.debug("Only advancing
complete node");
} else if (1 - cprobs[completeIndex] > probMass) {
setIncomplete(updatedNode);
newParse2.addProb(StrictMath.log(1 - cprobs[completeIndex]));
- if (debugOn) System.out.println("Only advancing incomplete
node");
+ if (logger.isDebugEnabled()) logger.debug("Only advancing
incomplete node");
} else {
setComplete(updatedNode);
Parse newParse3 = newParse2.cloneRoot(updatedNode,
originalZeroIndex);
newParse3.addProb(StrictMath.log(cprobs[completeIndex]));
newParsesList.add(newParse3);
setIncomplete(updatedNode);
newParse2.addProb(StrictMath.log(1 - cprobs[completeIndex]));
- if (debugOn)
- System.out.println("Advancing both complete and incomplete
nodes; c="
+ if (logger.isDebugEnabled())
+ logger.debug("Advancing both complete and incomplete
nodes; c="
Review Comment:
https://issues.apache.org/jira/browse/OPENNLP-1450
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
