[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692850#comment-17692850
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116137265
##########
opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesTrainer.java:
##########
@@ -228,7 +233,7 @@ private double trainingStats(EvalParameters evalParams) {
}
}
double trainingAccuracy = (double) numCorrect / numEvents;
- display("Stats: (" + numCorrect + "/" + numEvents + ") " +
trainingAccuracy + "\n");
+ logger.info("Stats: (" + numCorrect + "/" + numEvents + ") " +
trainingAccuracy);
Review Comment:
Variable replacement is tracked with
https://issues.apache.org/jira/browse/OPENNLP-1450 (next iteration, next topic
:-) )
##########
opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java:
##########
@@ -439,22 +442,10 @@ private double trainingStats(EvalParameters evalParams) {
}
}
double trainingAccuracy = (double) numCorrect / numEvents;
- display("Stats: (" + numCorrect + "/" + numEvents + ") " +
trainingAccuracy + "\n");
+ logger.info("Stats: (" + numCorrect + "/" + numEvents + ") " +
trainingAccuracy);
Review Comment:
https://issues.apache.org/jira/browse/OPENNLP-1450
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
