[ 
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692856#comment-17692856
 ] 

ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------

rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116141299


##########
opennlp-tools/src/main/java/opennlp/tools/formats/masc/MascDocumentStream.java:
##########
@@ -140,8 +143,7 @@ public MascDocumentStream(File mascCorpusDirectory,
               documents.add(MascDocument.parseDocument(hdrFilePath, f_primary, 
f_seg,
                   f_penn, f_s, f_ne));
             } catch (IOException e) {
-              System.err.println("Failed to parse the file: " + hdrFilePath);
-              System.err.println('\t' + e.getMessage());
+              logger.warn("Failed to parse the file: {}", hdrFilePath, e);

Review Comment:
   +1 -> https://issues.apache.org/jira/browse/OPENNLP-1449





> Introduce SLF4J in OpenNLP
> --------------------------
>
>                 Key: OPENNLP-1448
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1448
>             Project: OpenNLP
>          Issue Type: Sub-task
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is 
> configurable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to