[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692855#comment-17692855
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116140811
##########
opennlp-tools/src/main/java/opennlp/tools/formats/masc/MascDocument.java:
##########
@@ -353,7 +353,7 @@ private void addPennTags(Map<String, Map<Integer, ?>>
tagMaps) throws IOExceptio
//Check that all tokens have at least one quark.
for (Map.Entry<Integer, int[]> token : tokenToQuarks.entrySet()) {
if (token.getValue().length == 0) {
- System.err.println("[ERROR] Token without quarks: " +
token.getKey());
+ logger.error("Token without quarks: {}", token.getKey());
Review Comment:
I agree with `warn` here. We can change within
https://issues.apache.org/jira/browse/OPENNLP-1449 (next sub-task, next topic).
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
