[
https://issues.apache.org/jira/browse/OPENNLP-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692860#comment-17692860
]
ASF GitHub Bot commented on OPENNLP-1448:
-----------------------------------------
rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116142935
##########
opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java:
##########
@@ -391,7 +394,7 @@ private MutableContext[] findParameters(int iterations,
boolean useAverage) {
if (StrictMath.abs(prevAccuracy1 - trainingAccuracy) < tolerance
&& StrictMath.abs(prevAccuracy2 - trainingAccuracy) < tolerance
&& StrictMath.abs(prevAccuracy3 - trainingAccuracy) < tolerance) {
- display("Stopping: change in training set accuracy less than " +
tolerance + "\n");
+ logger.info("Stopping: change in training set accuracy less than {}",
tolerance);
Review Comment:
Would make sense in this context, yes. Previously was a plain Sys.out
We can change with https://issues.apache.org/jira/browse/OPENNLP-1449
> Introduce SLF4J in OpenNLP
> --------------------------
>
> Key: OPENNLP-1448
> URL: https://issues.apache.org/jira/browse/OPENNLP-1448
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
>
> This will be the first step regarding OPENNLP-1447.
> Goal is to replace System.err / System.out calls with logger output, which is
> configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
