style95 commented on code in PR #5333:
URL: https://github.com/apache/openwhisk/pull/5333#discussion_r991134151
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -606,12 +606,7 @@ class FunctionPullingContainerProxy(
if (runningActivations.isEmpty) {
logging.info(this, s"The Client closed in state: $stateName, action:
${data.action}")
// Stop ContainerProxy(ActivationClientProxy will stop also when send
ClientClosed to ContainerProxy).
- cleanUp(
- data.container,
- data.invocationNamespace,
- data.action.fullyQualifiedName(withVersion = true),
- data.action.rev,
- None)
+ cleanUp(data.container, None, false)
Review Comment:
This just deletes the container only as data is already removed here.
https://github.com/apache/openwhisk/pull/5333/files#diff-23fc1c1634cd8a2e99b4cfbf342527248a53f5987911af80ab5d910ce7864d70R623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
