style95 commented on code in PR #5333:
URL: https://github.com/apache/openwhisk/pull/5333#discussion_r992899171
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -606,12 +606,7 @@ class FunctionPullingContainerProxy(
if (runningActivations.isEmpty) {
logging.info(this, s"The Client closed in state: $stateName, action:
${data.action}")
// Stop ContainerProxy(ActivationClientProxy will stop also when send
ClientClosed to ContainerProxy).
- cleanUp(
- data.container,
- data.invocationNamespace,
- data.action.fullyQualifiedName(withVersion = true),
- data.action.rev,
- None)
+ cleanUp(data.container, None, false)
Review Comment:
All data are supposed to be removed after lease timeout this is because no
more keepalive request is sent when an invoker is unexpectedly terminated.
The default timeout is 10s. So there can be wrong data for 10s.
It's a tradeoff. When there is a temporal network rupture and no keepalive
could be sent to ETCD, the data can be unexpectedly removed if this timeout is
too short.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
