bdoyle0182 commented on code in PR #5333:
URL: https://github.com/apache/openwhisk/pull/5333#discussion_r992554133
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -624,6 +619,15 @@ class FunctionPullingContainerProxy(
// ContainerProxy will be terminated by StateTimeout if there is no
further activation
case Event(GracefulShutdown, data: WarmData) =>
logging.info(this, s"receive GracefulShutdown for action:
${data.action}")
+ // clean up the etcd data first so that the scheduler can provision more
containers in advance.
+ dataManagementService ! UnregisterData(
Review Comment:
Tangential but would it be useful to add an api to the invoker to show 1.
how many action containers are still active from the container pool and 2. by
action how many containers there are? That way you can use the api to check if
the disabling process has completed when all containers are shut down and it's
safe to shutdown the service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
