bdoyle0182 commented on code in PR #5333:
URL: https://github.com/apache/openwhisk/pull/5333#discussion_r992559556
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -606,12 +606,7 @@ class FunctionPullingContainerProxy(
if (runningActivations.isEmpty) {
logging.info(this, s"The Client closed in state: $stateName, action:
${data.action}")
// Stop ContainerProxy(ActivationClientProxy will stop also when send
ClientClosed to ContainerProxy).
- cleanUp(
- data.container,
- data.invocationNamespace,
- data.action.fullyQualifiedName(withVersion = true),
- data.action.rev,
- None)
+ cleanUp(data.container, None, false)
Review Comment:
It's guaranteed that the etcd data will be cleaned up right since the data
management service will retry indefinitely once it receives it? Is there any
case this condition can be hit without the `GracefulShutdown` event occurring?
Sort of a side question but what happens to etcd data if an invoker instance
is lost unexpectedly? If the invoker is lost is the data stuck indefinitely
until an invoker with the same id is restarted to wipe it on startup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
