style95 commented on code in PR #5442: URL: https://github.com/apache/openwhisk/pull/5442#discussion_r1322074596
########## common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala: ########## @@ -72,16 +76,19 @@ class PoolingRestClient( // Additional queue in case all connections are busy. Should hardly ever be // filled in practice but can be useful, e.g., in tests starting many // asynchronous requests in a very short period of time. - private val requestQueue = Source - .queue(queueSize, OverflowStrategy.dropNew) Review Comment: ~~If the overflow strategy is not specified, what happens now in case the queue is full?~~ Ok, now BoundedSourceQueueStage is used and it will immediately let us know if we can enqueue an element or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
