joni-jones commented on code in PR #5442:
URL: https://github.com/apache/openwhisk/pull/5442#discussion_r1329309691
##########
common/scala/src/main/scala/org/apache/openwhisk/core/database/CouchDbRestClient.scala:
##########
@@ -42,9 +42,11 @@ import scala.concurrent.{ExecutionContext, Future}
class CouchDbRestClient(protocol: String, host: String, port: Int, username:
String, password: String, db: String)(
implicit system: ActorSystem,
logging: Logging)
- extends PoolingRestClient(protocol, host, port, 16 * 1024) {
+ extends PoolingRestClient(protocol, host, port, 16 * 1024)(
+ system,
+ system.dispatchers.lookup("dispatchers.couch-dispatcher")) {
Review Comment:
The future `onComplete` requires an execution context, but because
`onComplete` is defined during class initialization it doesn't have a proper
execution context in the case of `CouchDbRestClient` because the child class is
initialized later than the parent.
I kept the protected property in `CouchDbRestClient` because its children
depend on it, there is at least one implementation inside OW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
