style95 commented on code in PR #5442:
URL: https://github.com/apache/openwhisk/pull/5442#discussion_r1322128748
##########
common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala:
##########
@@ -48,6 +50,8 @@ class PoolingRestClient(
timeout: Option[FiniteDuration] = None)(implicit system: ActorSystem) {
require(protocol == "http" || protocol == "https", "Protocol must be one of
{ http, https }.")
+ private val logging = new AkkaLogging(system.log)
Review Comment:
Got it.
[The log store
SPI](https://github.com/apache/openwhisk/blob/master/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/LogStore.scala#L101)
does not pass an implicit parameter for logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
