joni-jones commented on code in PR #5442:
URL: https://github.com/apache/openwhisk/pull/5442#discussion_r1322091799
##########
common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala:
##########
@@ -127,7 +134,13 @@ class PoolingRestClient(
}
}
- def shutdown(): Future[Unit] = Future.unit
+ def shutdown(): Future[Unit] = {
+ killSwitch.shutdown()
+ Try(requestQueue.complete()).recover {
+ case t: IllegalStateException => logging.error(this, t.getMessage)
Review Comment:
For our service, we decided to have a log record of this exception as we can
track such a situation and see if the number of such exceptions gets worse,
which might help to investigate other issues. Also, personally, I don't like
the approach of silently ignoring exceptions.
In our case, if the exception propagated to the dependable code it will
break the k8s containers clean up which will lead to thousands of abandoned
containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
