rabbah commented on a change in pull request #2624: Add cache invalidation
between controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2624#discussion_r133848952
##########
File path:
common/scala/src/main/scala/whisk/core/database/MultipleReadersSingleWriterCache.scala
##########
@@ -150,11 +153,13 @@ trait MultipleReadersSingleWriterCache[W, Winfo] {
* This method posts a delete to the backing store, and either directly
invalidates the cache entry
* or informs any outstanding transaction that it must invalidate the
cache on completion.
*/
- protected def cacheInvalidate[R](key: Any, invalidator: => Future[R])(
+ protected def cacheInvalidate[R](key: CacheKey, invalidator: => Future[R],
changeCacheCallback: CacheKey => Future[Unit] = CacheKey =>
Future.successful(Unit))(
Review comment:
did you consider making the change callback an optional method on the trait?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
