rabbah commented on a change in pull request #2624: Add cache invalidation
between controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2624#discussion_r135630852
##########
File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala
##########
@@ -201,94 +199,101 @@ class RestAPIVersion(config: WhiskConfig, apiPath:
String, apiVersion: String)(
private val web = new WebActionsApi(Seq("web"), WebApiDirectives.web)
class NamespacesApi(
- val apiPath: String,
- val apiVersion: String)(
- implicit override val entityStore: EntityStore,
- override val entitlementProvider: EntitlementProvider,
- override val executionContext: ExecutionContext,
- override val logging: Logging)
- extends WhiskNamespacesApi
+ val apiPath: String,
+ val apiVersion: String)(
+ implicit override val entityStore: EntityStore,
+ override val entitlementProvider: EntitlementProvider,
+ override val executionContext: ExecutionContext,
+ override val logging: Logging)
+ extends WhiskNamespacesApi
class ActionsApi(
val apiPath: String,
val apiVersion: String)(
- implicit override val actorSystem: ActorSystem,
- override val activeAckTopicIndex: InstanceId,
- override val entityStore: EntityStore,
- override val activationStore: ActivationStore,
- override val entitlementProvider: EntitlementProvider,
- override val activationIdFactory: ActivationIdGenerator,
- override val loadBalancer: LoadBalancerService,
- override val executionContext: ExecutionContext,
- override val logging: Logging,
- override val whiskConfig: WhiskConfig)
- extends WhiskActionsApi with WhiskServices {
+ implicit override val actorSystem: ActorSystem,
+ override val activeAckTopicIndex: InstanceId,
+ override val entityStore: EntityStore,
+ override val activationStore: ActivationStore,
+ override val entitlementProvider: EntitlementProvider,
+ override val activationIdFactory: ActivationIdGenerator,
+ override val loadBalancer: LoadBalancerService,
+ override val executionContext: ExecutionContext,
+ override val logging: Logging,
+ override val whiskConfig: WhiskConfig)
+ extends WhiskActionsApi with WhiskServices {
logging.info(this, s"actionSequenceLimit
'${whiskConfig.actionSequenceLimit}'")
assert(whiskConfig.actionSequenceLimit.toInt > 0)
+ override def changeCacheCallback(key: CacheKey): Future[Unit] =
sendCacheInvalidation(key: CacheKey)
}
class ActivationsApi(
val apiPath: String,
val apiVersion: String)(
- implicit override val activationStore: ActivationStore,
- override val entitlementProvider: EntitlementProvider,
- override val executionContext: ExecutionContext,
- override val logging: Logging)
- extends WhiskActivationsApi
+ implicit override val activationStore: ActivationStore,
+ override val entitlementProvider: EntitlementProvider,
+ override val executionContext: ExecutionContext,
+ override val logging: Logging)
+ extends WhiskActivationsApi
class PackagesApi(
val apiPath: String,
val apiVersion: String)(
- implicit override val entityStore: EntityStore,
- override val entitlementProvider: EntitlementProvider,
- override val activationIdFactory: ActivationIdGenerator,
- override val loadBalancer: LoadBalancerService,
- override val executionContext: ExecutionContext,
- override val logging: Logging,
- override val whiskConfig: WhiskConfig)
- extends WhiskPackagesApi with WhiskServices
+ implicit override val entityStore: EntityStore,
+ override val entitlementProvider: EntitlementProvider,
+ override val activationIdFactory: ActivationIdGenerator,
+ override val loadBalancer: LoadBalancerService,
+ override val executionContext: ExecutionContext,
+ override val logging: Logging,
+ override val whiskConfig: WhiskConfig)
+ extends WhiskPackagesApi with WhiskServices {
+ override def changeCacheCallback(key: CacheKey): Future[Unit] =
sendCacheInvalidation(key: CacheKey)
+ }
class RulesApi(
val apiPath: String,
val apiVersion: String)(
- implicit override val actorSystem: ActorSystem,
- override val entityStore: EntityStore,
- override val entitlementProvider: EntitlementProvider,
- override val activationIdFactory: ActivationIdGenerator,
- override val loadBalancer: LoadBalancerService,
- override val executionContext: ExecutionContext,
- override val logging: Logging,
- override val whiskConfig: WhiskConfig)
- extends WhiskRulesApi with WhiskServices
+ implicit override val actorSystem: ActorSystem,
+ override val entityStore: EntityStore,
+ override val entitlementProvider: EntitlementProvider,
+ override val activationIdFactory: ActivationIdGenerator,
+ override val loadBalancer: LoadBalancerService,
+ override val executionContext: ExecutionContext,
+ override val logging: Logging,
+ override val whiskConfig: WhiskConfig)
+ extends WhiskRulesApi with WhiskServices {
+ override def changeCacheCallback(key: CacheKey): Future[Unit] =
sendCacheInvalidation(key: CacheKey)
+ }
class TriggersApi(
val apiPath: String,
val apiVersion: String)(
- implicit override val actorSystem: ActorSystem,
- implicit override val entityStore: EntityStore,
- override val entitlementProvider: EntitlementProvider,
- override val activationStore: ActivationStore,
- override val activationIdFactory: ActivationIdGenerator,
- override val loadBalancer: LoadBalancerService,
- override val executionContext: ExecutionContext,
- override val logging: Logging,
- override val whiskConfig: WhiskConfig,
- override val materializer: ActorMaterializer)
- extends WhiskTriggersApi with WhiskServices
+ implicit override val actorSystem: ActorSystem,
Review comment:
can we drop these formatting changes from this pr?
hopefully we will fix formatting wars soon once and for all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
