rabbah commented on a change in pull request #2624: Add cache invalidation
between controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2624#discussion_r135604910
##########
File path: common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
##########
@@ -83,6 +83,11 @@ protected[core] case class DocInfo protected[entity] (id:
DocId, rev: DocRevisio
s"$id.$rev".hashCode
}
}
+
+ def asCacheKey = {
Review comment:
I am thinking we do this slightly differently: rather than spread out all
the asCacheKey methods, instead have CacheKey constructors for the different
types we envision caching. This would avoid leaking this detail to the various
types and consolidates the changes one might need to make to a single singleton
for example that provides implicit or explicit conversion to CacheKey.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
