rabbah commented on a change in pull request #2624: Add cache invalidation
between controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2624#discussion_r135628119
##########
File path:
common/scala/src/main/scala/whisk/core/database/MultipleReadersSingleWriterCache.scala
##########
@@ -97,7 +99,7 @@ trait MultipleReadersSingleWriterCache[W, Winfo] {
protected val cacheEnabled = true
/** Subclasses: tell me what key to use for updates. */
- protected def cacheKeyForUpdate(w: W): Any
+ protected def cacheKeyForUpdate(w: W): CacheKey
Review comment:
with the introduction of `CacheKey` you may be able to just nuke this method
(if you introduce constructors for the various types as suggested below).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
