rabbah commented on a change in pull request #2624: Add cache invalidation 
between controllers
URL: 
https://github.com/apache/incubator-openwhisk/pull/2624#discussion_r135582736
 
 

 ##########
 File path: 
common/scala/src/main/scala/whisk/core/database/MultipleReadersSingleWriterCache.scala
 ##########
 @@ -287,19 +294,25 @@ trait MultipleReadersSingleWriterCache[W, Winfo] {
 
     def cacheSize: Int = cache.size
 
+    protected[database] def removeId(key: CacheKey)(implicit ec: 
ExecutionContext) = {
 
 Review comment:
   javadoc this - what's the expectation here - do you need the result (ie why 
bother unpacking)?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to