[
https://issues.apache.org/jira/browse/ORC-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001478#comment-16001478
]
ASF GitHub Bot commented on ORC-185:
------------------------------------
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r115346953
--- Diff: c++/src/Statistics.hh ---
@@ -41,49 +41,181 @@ namespace orc {
};
/**
+ * Internal Statistics Implementation
+ */
+
+ template <typename T>
+ class InternalStatisticsImpl {
+ private:
+ bool hasNull_;
--- End diff --
Not sure if this is right time to enforce a new coding style. We have an
existing code base roughly about 10,000 lines. It's quite a bit of effort to
convert existing code into proposed style. What's the problem with current
style? Or ask it differently - what is the benefit of moving over to google
style?
> [C++] Simplify Statististics Implementation
> -------------------------------------------
>
> Key: ORC-185
> URL: https://issues.apache.org/jira/browse/ORC-185
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> There is a lot of code duplication in the current ColumnStatistics
> implementation. The scope of this JIRA is to use templates to reuse code as
> much as possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
