[
https://issues.apache.org/jira/browse/ORC-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003583#comment-16003583
]
ASF GitHub Bot commented on ORC-185:
------------------------------------
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r115606228
--- Diff: c++/src/Statistics.hh ---
@@ -41,49 +41,181 @@ namespace orc {
};
/**
+ * Internal Statistics Implementation
+ */
+
+ template <typename T>
+ class InternalStatisticsImpl {
+ private:
+ bool hasNull_;
--- End diff --
Personally I don't have any problem with the current style. I don't even
notice the inconsistency (should have pay more attentions to style, :)). But to
me, missing writer is a big functionality gap that needs to be filled in
quickly.
Having said that I think this is eventually a call from @omalley and other
major committers. If we really want to enforce a new style, we should always
update the existing code first before adding new codes with new style.
Otherwise the code base is going to look even worse until we fix everything.
> [C++] Simplify Statististics Implementation
> -------------------------------------------
>
> Key: ORC-185
> URL: https://issues.apache.org/jira/browse/ORC-185
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> There is a lot of code duplication in the current ColumnStatistics
> implementation. The scope of this JIRA is to use templates to reuse code as
> much as possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
