[
https://issues.apache.org/jira/browse/ORC-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001512#comment-16001512
]
ASF GitHub Bot commented on ORC-185:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r115351107
--- Diff: c++/src/Statistics.hh ---
@@ -41,49 +41,181 @@ namespace orc {
};
/**
+ * Internal Statistics Implementation
+ */
+
+ template <typename T>
+ class InternalStatisticsImpl {
+ private:
+ bool hasNull_;
--- End diff --
The problem with the current style is that there are no guidelines and is
not consistent as well. I see some variables beginning with an `_` and some
don't.
In other projects, I found the google style very helpful to read code.
Especially when I have to revisit the code after some months. The style allows
me to easily distinguish a class member vs a local member. Now that we plan to
add the writer, the code base is only going to increase significantly. I felt
this is the right time to introduce a standard moving forward. A standard helps
people new to the code base too.
> [C++] Simplify Statististics Implementation
> -------------------------------------------
>
> Key: ORC-185
> URL: https://issues.apache.org/jira/browse/ORC-185
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> There is a lot of code duplication in the current ColumnStatistics
> implementation. The scope of this JIRA is to use templates to reuse code as
> much as possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
