JacksonYao287 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r639342133
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java
##########
@@ -286,6 +286,23 @@ Pipeline
createReplicationPipeline(HddsProtos.ReplicationType type,
*/
boolean getReplicationManagerStatus() throws IOException;
+ /**
+ * Start ContainerBalancer.
+ */
+ void startContainerBalancer() throws IOException;
Review comment:
yes , i keep it like this , because for now we can not determine how
these parameters will be used or should we add more parameters(like bandwidth,
which determines the maximum speed at which a block will be moved from one
datanode to another ). I just implement the simplest function for now, and i
think it will not be hard to complete the full implementation of this after we
review the design doc and make the final decision.
```
public void execute(ScmClient scmClient) throws IOException {
scmClient.startContainerBalancer();
LOG.info("Starting ContainerBalancer...");
//remove these in later implementation
LOG.info("threshold: {}", threshold);
LOG.info("idleiterations: {}", iCount);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
