lokeshj1703 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r642274979
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java
##########
@@ -611,6 +638,28 @@ public ReplicationManagerStatusResponseProto
getReplicationManagerStatus(
.setIsRunning(impl.getReplicationManagerStatus()).build();
}
+ public StartContainerBalancerResponseProto startContainerBalancer(
+ StartContainerBalancerRequestProto request)
+ throws IOException {
+ impl.startContainerBalancer();
+ return StartContainerBalancerResponseProto.newBuilder().build();
+ }
Review comment:
What Siddhant is suggesting is that before calling
ContainerBalancer#start, a ContainerBalancerConfiguration can be generated from
the input parameters. If user passes parameter of threshold as 0.05, it can be
set in the configuration object and then the conf object can be passed to
balancer. No other change would be required in Balancer.
@siddhantsangwan Please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
