siddhantsangwan commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r640357420
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java
##########
@@ -611,6 +638,28 @@ public ReplicationManagerStatusResponseProto
getReplicationManagerStatus(
.setIsRunning(impl.getReplicationManagerStatus()).build();
}
+ public StartContainerBalancerResponseProto startContainerBalancer(
+ StartContainerBalancerRequestProto request)
+ throws IOException {
+ impl.startContainerBalancer();
+ return StartContainerBalancerResponseProto.newBuilder().build();
+ }
Review comment:
Can we pass the parameters in the request to
`ContainerBalancerConfiguration`?
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -63,16 +68,14 @@ public ContainerBalancer(
/**
* Start ContainerBalancer. Current implementation is incomplete.
- *
- * @param balancerConfiguration Configuration values.
*/
- public void start(ContainerBalancerConfiguration balancerConfiguration) {
+ public void start() {
this.balancerRunning = true;
ozoneConfiguration = new OzoneConfiguration();
// initialise configs
- this.config = balancerConfiguration;
+ //this.config = balancerConfiguration;
Review comment:
`ContainerBalancerConfiguration` can be updated with any CLI params and
then used as a single source of configurations wherever needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
