siddhantsangwan commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r642267250
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -63,16 +68,14 @@ public ContainerBalancer(
/**
* Start ContainerBalancer. Current implementation is incomplete.
- *
- * @param balancerConfiguration Configuration values.
*/
- public void start(ContainerBalancerConfiguration balancerConfiguration) {
+ public void start() {
this.balancerRunning = true;
ozoneConfiguration = new OzoneConfiguration();
// initialise configs
- this.config = balancerConfiguration;
+ //this.config = balancerConfiguration;
Review comment:
Since these parameters are required in multiple classes, we can set
these fields in the `ContainerBalancerConfiguration` class and then pass this
object to wherever parameters are required. This way, all parameters will be
present in one place instead of being get/set in different places. It could be
better to maintain all the parameters in a single class. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
