JacksonYao287 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r640532246
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -63,16 +68,14 @@ public ContainerBalancer(
/**
* Start ContainerBalancer. Current implementation is incomplete.
- *
- * @param balancerConfiguration Configuration values.
*/
- public void start(ContainerBalancerConfiguration balancerConfiguration) {
+ public void start() {
this.balancerRunning = true;
ozoneConfiguration = new OzoneConfiguration();
// initialise configs
- this.config = balancerConfiguration;
+ //this.config = balancerConfiguration;
Review comment:
@siddhantsangwan Thanks for the review! we can just specify some
important parameters for now I think and then keep on adding params as required
. we can add more params as we move forward with the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
