smengcl commented on code in PR #9813:
URL: https://github.com/apache/ozone/pull/9813#discussion_r3533135177
##########
hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedDBOptions.java:
##########
@@ -34,7 +34,6 @@ public class ManagedDBOptions extends DBOptions {
private final UncheckedAutoCloseable leakTracker = track(this);
private final AtomicReference<Logger> loggerRef = new AtomicReference<>();
- @Override
Review Comment:
Actually, JNI in v10 no longer has setLogger(logger). So this is overload
now, not override. Changed in:
https://github.com/facebook/rocksdb/commit/4835c11cce4d#diff-1536c1746bb06ab2e37be82324b437afc6b0ee159394d0d2c804532515f5a70aL215-L220
Compared with v7.7.3:
https://github.com/facebook/rocksdb/blob/v7.7.3/java/src/main/java/org/rocksdb/DBOptions.java#L219-L224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
