smengcl commented on code in PR #9813:
URL: https://github.com/apache/ozone/pull/9813#discussion_r3533146818
##########
hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRocksDB.java:
##########
@@ -112,18 +113,23 @@ public static ManagedRocksDB openWithLatestOptions(
}
/**
- * Delete liveMetaDataFile from rocks db using RocksDB#deleteFile Api.
- * This function makes the RocksDB#deleteFile Api synchronized by waiting
- * for the deletes to happen.
- * @param fileToBeDeleted File to be deleted.
+ * Delete the SST file range from rocks db and wait for file deletion.
+ * @param columnFamilyHandle column family of the target sst file.
+ * @param fileToBeDeleted file metadata to be deleted.
* @throws RocksDatabaseException if the underlying db throws an exception
* or the file is not deleted within a time
limit.
*/
- public void deleteFile(LiveFileMetaData fileToBeDeleted) throws
RocksDatabaseException {
- String sstFileName = fileToBeDeleted.fileName();
+ public void deleteFile(
+ ColumnFamilyHandle columnFamilyHandle,
+ LiveFileMetaData fileToBeDeleted) throws RocksDatabaseException {
Review Comment:
Migrated. Thanks @ptlrs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
