smengcl commented on code in PR #9813:
URL: https://github.com/apache/ozone/pull/9813#discussion_r3540091674
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/hadoop/hdds/utils/db/RDBSstFileWriter.java:
##########
@@ -36,8 +37,13 @@ public class RDBSstFileWriter implements Closeable {
private AtomicLong keyCounter;
private ManagedOptions emptyOption = new ManagedOptions();
private final ManagedEnvOptions emptyEnvOptions = new ManagedEnvOptions();
+ private final ManagedBlockBasedTableConfig tableConfig = new
ManagedBlockBasedTableConfig();
public RDBSstFileWriter(File externalFile) throws RocksDatabaseException {
+ // Pin the SST format version so files written here (e.g. snapshot defrag
+ // ingest) stay readable if Ozone is downgraded before finalization.
+ tableConfig.setFormatVersion(ManagedBlockBasedTableConfig.FORMAT_VERSION);
Review Comment:
Let's file JIRAs for those.
Filed https://issues.apache.org/jira/browse/HDDS-15769 for 2.1 and 2.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
