smengcl commented on code in PR #9813:
URL: https://github.com/apache/ozone/pull/9813#discussion_r3533195375
##########
hadoop-hdds/rocks-native/src/main/patches/rocks-native.patch:
##########
@@ -380,9 +381,9 @@ index 000000000..5ba8a82ee
+
+ rep_->file_.reset(new RandomAccessFileReader(std::move(file), file_path));
+
-+ FilePrefetchBuffer prefetch_buffer(
-+ 0 /* readahead_size */, 0 /* max_readahead_size */, true /* enable */,
-+ false /* track_min_offset */);
++ FilePrefetchBuffer prefetch_buffer(ReadaheadParams(),
++ !fopts.use_mmap_reads /* enable */,
++ false /* track_min_offset */);
+ if (s.ok()) {
Review Comment:
`raw_sst_file_reader.cc` is right inside this patch file.
I believe the header you are trying to find is
`file/file_prefetch_buffer.h`. The constructor has been changed in
https://github.com/facebook/rocksdb/commit/5cb2d09d4762
Thus `raw_sst_file_reader.cc` must follow the changes to
`table/sst_file_dumper.cc`:
https://github.com/facebook/rocksdb/commit/5cb2d09d4762#diff-a3d4e6aa344de24bb85c472a34af1e00b9cde125fbfb0afe994ca539328f953d
https://github.com/facebook/rocksdb/commit/ed46981bea38#diff-a3d4e6aa344de24bb85c472a34af1e00b9cde125fbfb0afe994ca539328f953d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
