Copilot commented on code in PR #9813:
URL: https://github.com/apache/ozone/pull/9813#discussion_r3533973082
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java:
##########
@@ -888,6 +891,12 @@ public void deleteFilesNotMatchingPrefix(TablePrefixInfo
prefixInfo) throws Rock
boolean isKeyWithPrefixPresent = RocksDiffUtils.isKeyWithPrefixPresent(
prefixForColumnFamily, firstDbKey, lastDbKey);
if (!isKeyWithPrefixPresent) {
+ ColumnFamilyHandle handle =
getColumnFamilyHandle(sstFileColumnFamily);
+ if (handle == null) {
+ LOG.warn("Skipping sst file deletion for {}: no handle found for
column family {}",
+ liveFileMetaData.fileName(), sstFileColumnFamily);
+ continue;
Review Comment:
The level-check comment above this block still refers to the removed
RocksDB#deleteFile behavior, but the implementation now deletes via
deleteFilesInRanges (ManagedRocksDB.deleteSstFileRange). Please update the
comment to describe the current rationale; otherwise it’s misleading for future
maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
