sadanand48 commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3680710472
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1231,20 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>>
newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws
IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles =
deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ",
deltaFiles.size());
- }
+ LOG.info("Computed Delta SST File Set for table '{}', file count: {},
elapsed: {}ms, jobId: {}",
Review Comment:
It looks like for each successful snapshot diff call, it will generate
around 6-7 info log statements. I think the per stage ones could be at the
debug level itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
