SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3685951118
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1235,22 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>>
newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws
IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles =
deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ",
deltaFiles.size());
+ LOG.debug("Computed Delta SST File Set for table '{}', file count: {},
elapsed: {}ms, jobId: {}",
+ fsTable.getName(), deltaFiles.size(), Time.monotonicNow() -
deltaFilesStart, jobId);
}
+ recordActivity(jobKey,
+ fsTable.getName().equals(DIRECTORY_TABLE) ? OBJECT_ID_MAP_GEN_FSO :
OBJECT_ID_MAP_GEN_OBS);
Review Comment:
Thanks for the path @rhalm. The sub status here would be
`OBJECT_ID_MAP_GEN_OBS` for `fileTable` which is confusing. This was also an
existing bug.
Could we split `OBJECT_ID_MAP_GEN_FSO` to maybe `OBJECT_ID_MAP_GEN_FSO_FILE`
for `fileTable` and `OBJECT_ID_MAP_GEN_FSO_DIR` for `directoryTable`?
`keyTable` objectID gen stage can continue to use `OBJECT_ID_MAP_GEN_OBS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
