SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686167547
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1112,27 +1114,27 @@ void generateSnapshotDiffReport(final String jobKey,
// repetition while constantly checking if the job is cancelled.
Callable<Void>[] methodCalls = new Callable[]{
() -> {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_OBS);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsKeyTable, tsKeyTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_FSO);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsDirTable,
tsDirTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey,
jobId);
}
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
+ recordActivity(jobKey, PATH_RESOLUTION_FSO);
Review Comment:
Progress for `PATH_RESOLUTION_FSO` and `DIFF_REPORT_GEN` is currently not
logged. Can you explore how we can capture the progress of these stages as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
