SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686145814
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1334,10 @@ void addToObjectIdMap(Table<String, ? extends
WithParentObjectId> fsTable,
}
}
}
Review Comment:
In most cases `Total keysProcessed < totalEstimatedKeysToProcess`. So, the
progress may never reach 100% inside the loop. You can set it after the loop to
indicate that the stage has finished.
```suggestion
}
updateProgress(jobKey, 1.0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
