rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3691590146
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1235,22 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>>
newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws
IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles =
deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ",
deltaFiles.size());
+ LOG.debug("Computed Delta SST File Set for table '{}', file count: {},
elapsed: {}ms, jobId: {}",
+ fsTable.getName(), deltaFiles.size(), Time.monotonicNow() -
deltaFilesStart, jobId);
}
+ recordActivity(jobKey,
+ fsTable.getName().equals(DIRECTORY_TABLE) ? OBJECT_ID_MAP_GEN_FSO :
OBJECT_ID_MAP_GEN_OBS);
Review Comment:
Thanks for the review. Split into `OBJECT_ID_MAP_GEN_FSO_FILE` and
`OBJECT_ID_MAP_GEN_FSO_DIR` as suggested. I kept `OBJECT_ID_MAP_GEN_FSO` as
deprecated purely for an upgrade edge case where an older build may have
persisted this value to RocksDB as JSON, and since the codec's JSON fallback
path deserializes enums by name, removing it could cause a failure. Very
unlikely scenario, but better to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
