sodonnel commented on code in PR #4006: URL: https://github.com/apache/ozone/pull/4006#discussion_r1035861770
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java: ########## @@ -69,7 +69,7 @@ private final ConfigurationSource conf; private final boolean shouldRemovePeers; - private Function<ContainerReplica, RID> replicaIdentifierFunction; + private Function<ContainerReplica, Integer> replicaIdentifierFunction; Review Comment: This comment is still unresolved - we don't need to pass a function to get the replicaIndex out of the containerReplica object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
