sodonnel commented on code in PR #4006:
URL: https://github.com/apache/ozone/pull/4006#discussion_r1035875149
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -426,4 +434,41 @@ public boolean isValidNode(DatanodeDetails datanodeDetails,
}
return false;
}
+
+ @Override
+ public Set<ContainerReplica> replicasToCopy(
+ Set<ContainerReplica> replicas, int expectedCountPerUniqueReplicas,
Review Comment:
I know it was me who suggested the parameters here, but we we actually need
`expectedCountPerUniqueReplicas` and `expectedUniqueGroups` to solve this
problem for anything we currently know about? I think that give a Set of
replicas that is otherwise not mis-replicated, we don't need these things.
The number of replicas is the Set size, and each replica given is "unique"
from a plaement perspective.
I cannot thing of any other sort of placement policy that needs more
information than that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
