sodonnel commented on code in PR #4006:
URL: https://github.com/apache/ozone/pull/4006#discussion_r1035879644
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestContainerPlacementFactory.java:
##########
@@ -191,6 +194,13 @@ public List<DatanodeDetails> chooseDatanodes(
validateContainerPlacement(List<DatanodeDetails> dns, int replicas) {
return new ContainerPlacementStatusDefault(1, 1, 1);
}
+
+ @Override
+ public Set<ContainerReplica> replicasToCopy(
+ Set<ContainerReplica> replicas, int expectedCountPerUniqueReplica,
+ int expectedUniqueGroups) {
+ return null;
Review Comment:
Probably best to return emptySet here rather than null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
