sodonnel commented on code in PR #4006:
URL: https://github.com/apache/ozone/pull/4006#discussion_r1035885317
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java:
##########
@@ -59,17 +70,64 @@ public void testGetResultSet() throws SCMException {
Assertions.assertNotEquals(1, resultSet.size());
}
- private static class DummyPlacementPolicy extends SCMCommonPlacementPolicy {
+ @Test
Review Comment:
I think we want to have some tests in each of the placement polices for
this, or at least vary the expected number of racks and replicas a bit.
Also test for the case where there is nothing to copy and it returns empty
set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
