aswinshakil commented on code in PR #5301:
URL: https://github.com/apache/ozone/pull/5301#discussion_r1329161619
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1815,6 +1818,16 @@ message SnapshotPurgeRequest {
repeated string updatedSnapshotDBKey = 2;
}
+message SnapshotUpdateSizeRequest {
+ repeated SnapshotSize snapshotSize = 1;
+}
+
+message SnapshotSize {
Review Comment:
We can generalise this, but we shouldn't send the snapshot info as it is.
Imagine this case,
1) I get `SnapshotInfo` in KeyDeletetingService, the snapshot is still
active.
2) Now someone deletes the snapshot, So snapshot metadata says
SnapshotDeleted.
3) Now when I update the SnapshotInfo it still says it's active. Though the
snapshot is deleted, we will make it active again with this flow and it will
never be GCed. This is the same for all the other metadata in the snapshot as
well.
Your thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
